Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugger: Fix inconsistent inspector output of exec new Map() #42423

Merged
merged 1 commit into from May 8, 2022
Merged

debugger: Fix inconsistent inspector output of exec new Map() #42423

merged 1 commit into from May 8, 2022

Conversation

cola119
Copy link
Contributor

@cola119 cola119 commented Mar 21, 2022 •
edited

Fixed #42405

The output string of exec command is from RemoteObject[customInspectSymbol], but currently it doesn't support some object types such as Map and Set, which leads to invalid string representations (#42405).

This PR implemented string representations when RemoteObject.subtype is set and map. RemoteObject has their abbreviation as ObjectPreview in RemoteObject.preview, which means we can construct their string representation from ObjectPreview.

For example, new Set([ {a: 1}, new Set([1]) ]) is a RemoteObject that has two ObjectPreviews ({a: 1} and new Set([1])).
String representation of ObjectPreview {a: 1} will be {a: 1} and new Set([1]) will be Set(1) { ... }. (Note that ObjectPreview treats an object nested in two or more layers as overflow, so overflowed object is converted to { ... })

1d0da48 added test cases for object type RemoteObject
7820dd4 added ObjectPreview and PropertyPreview. And current string representation logics are ported to them.
5a4f767 fixed string representations of Map and Set.

@nodejs-github-bot nodejs-github-bot added debugger needs-ci labels Mar 21, 2022
@Trott Trott requested a review from jkrems Mar 22, 2022
jkrems
jkrems approved these changes Mar 23, 2022
View changes
Copy link
Contributor

@jkrems jkrems left a comment

Thanks for fixing this! I like the new split here, just one nit/question.

lib/internal/debugger/inspect_repl.js Show resolved Hide resolved
@cola119 cola119 changed the title debugger: Fix Inconsistent inspector output of exec new Map() debugger: Fix inconsistent inspector output of exec new Map() Mar 23, 2022
@meixg meixg added the request-ci label Apr 17, 2022
@github-actions github-actions bot removed the request-ci label Apr 17, 2022
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 17, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43541/

@Trott
Copy link
Member

@Trott Trott commented Apr 17, 2022

The way these three commits are organized, the first commit adds a test that fails. This will break git bisect. Can you either move that commit to the end, or else squash the three commits together?

@cola119
Copy link
Contributor Author

@cola119 cola119 commented Apr 17, 2022 •
edited

@Trott I squashed them into the one.

@Trott Trott added the request-ci label Apr 17, 2022
Trott
Trott approved these changes Apr 17, 2022
View changes
@github-actions github-actions bot removed the request-ci label Apr 17, 2022
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 17, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43547/

@github-actions github-actions bot mentioned this pull request Apr 18, 2022
Open
14 tasks
jkrems
jkrems approved these changes Apr 18, 2022
View changes
@github-actions github-actions bot mentioned this pull request Apr 19, 2022
Open
16 tasks
@github-actions github-actions bot mentioned this pull request Apr 20, 2022
Open
16 tasks
jasnell
jasnell reviewed Apr 20, 2022
View changes
test/parallel/test-debugger-object-type-remote-object.js Outdated
throw error;
}

cli.waitForInitialBreak()
Copy link
Member

@jasnell jasnell Apr 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oy... rather than a long chain of thens... can we convert this into an async function with awaits please?

Copy link
Contributor Author

@cola119 cola119 Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell done 3f21ce5

@github-actions github-actions bot mentioned this pull request Apr 21, 2022
Open
22 tasks
@github-actions github-actions bot mentioned this pull request Apr 22, 2022
Open
19 tasks
@cola119 cola119 requested a review from jasnell Apr 22, 2022
@cola119
Copy link
Contributor Author

@cola119 cola119 commented May 7, 2022

@Trott @jasnell @jkrems Sorry for bothering you. Could you land this when you are free. Thank you.

@Trott Trott added the request-ci label May 7, 2022
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented May 7, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43913/

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented May 7, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43915/

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented May 7, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43916/

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented May 7, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43917/

@Trott
Copy link
Member

@Trott Trott commented May 8, 2022

Failing test on ARM?

11:18:48 not ok 3359 parallel/test-debugger-object-type-remote-object
11:18:48   ---
11:18:48   duration_ms: 360.28
11:18:48   severity: fail
11:18:48   exitcode: -15
11:18:48   stack: |-
11:18:48     timeout
11:18:48   ...

Trott
Trott requested changes May 8, 2022
View changes
Copy link
Member

@Trott Trott left a comment •
edited

Failing test needs to be fixed? (Not sure if it's the lib code change here or the test itself.)

@cola119
Copy link
Contributor Author

@cola119 cola119 commented May 8, 2022

I think debugger-* test should be in test/sequential/.

@Trott
Copy link
Member

@Trott Trott commented May 8, 2022

I think debugger-* test should be in test/sequential/.

Most of them are. Maybe this one should be too. The ones in parallel should either not open a port or open a system-provided arbitrary port.

@cola119 cola119 requested a review from Trott May 8, 2022
Trott
Trott approved these changes May 8, 2022
View changes
@Trott Trott added request-ci author ready labels May 8, 2022
@github-actions github-actions bot removed the request-ci label May 8, 2022
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented May 8, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43923/

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented May 8, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43925/

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented May 8, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43926/

@Trott Trott added the commit-queue label May 8, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue label May 8, 2022
@nodejs-github-bot nodejs-github-bot merged commit f890ef5 into nodejs:master May 8, 2022
53 checks passed
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented May 8, 2022

Landed in f890ef5

RafaelGSS pushed a commit that referenced this issue May 10, 2022
@cola119 @RafaelGSS
debugger: fix inconsistent inspector output of exec new Map()
946f57c 
PR-URL: #42423
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 10, 2022
Merged
@github-actions github-actions bot mentioned this pull request May 12, 2022
Open
30 tasks
@joyeecheung joyeecheung mentioned this pull request May 12, 2022
Open
@github-actions github-actions bot mentioned this pull request May 12, 2022
Closed
32 tasks
@github-actions github-actions bot mentioned this pull request May 13, 2022
Open
33 tasks
@github-actions github-actions bot mentioned this pull request May 14, 2022
Open
33 tasks
@github-actions github-actions bot mentioned this pull request May 15, 2022
Open
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkrems jkrems

@Trott Trott

@jasnell jasnell

Assignees
No one assigned
Labels
author ready debugger needs-ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent inspector output of exec new Map()
6 participants
@cola119 @nodejs-github-bot @Trott @jasnell @jkrems @meixg