Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for <ol reversed>, related attributes #396
Conversation
* Mark <ol reversed> as a boolean attribute so it serializes properly in HTML. * Allow <ol reversed> in the sanitizer. Closes #321. * Allow <ol start> in the sanitizer. * <ol type> was already allowed, but probably accidentally (type is an attribute allowed for other tags). I added a test to prevent it from regressing in case we add per-element attribute sanitization in the future. https://html.spec.whatwg.org/multipage/grouping-content.html#attr-ol-reversed
twm
added a commit
to twm/html5lib-python
that referenced
this pull request
Jun 10, 2018
It looks like this was missed in html5lib#358. It is causing build failures in html5lib#395 and html5lib#396.
gsnedders
added a commit
that referenced
this pull request
Oct 1, 2018
Codecov Report
@@ Coverage Diff @@
## master #396 +/- ##
=========================================
+ Coverage 90.79% 90.8% +0.01%
=========================================
Files 50 50
Lines 6952 6964 +12
Branches 1328 1328
=========================================
+ Hits 6312 6324 +12
Misses 481 481
Partials 159 159
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
<ol reversed>as a boolean attribute so it serializes properly in HTML.<ol reversed>in the sanitizer. Closes #321.<ol start>in the sanitizer.<ol type>was already allowed, but probably accidentally (type is an attribute allowed for other tags). I added a test to prevent it from regressing in case we add per-element attribute sanitization in the future.https://html.spec.whatwg.org/multipage/grouping-content.html#attr-ol-reversed