refactor: add a repr helper function for the collections#3471
Merged
Conversation
youknowone
requested changes
Nov 29, 2021
Contributor
Author
|
Those changes are really good ideas. I'll do that. |
0cef857 to
28a11bc
Compare
Member
|
I have no idea yet. But becasue it failed again exceeding the time limit, it seems this changes made something. |
Contributor
Try running the following command: |
28a11bc to
db8ce84
Compare
db8ce84 to
b11b165
Compare
Contributor
|
It was hanging in the snippets. To diagnose,
|
|
how far are we from completion here @TeamTamoad ? :) |
b11b165 to
0f4d6cd
Compare
Contributor
Author
|
Sorry for an late update. I'm super busy with life and college right now. # Test that calling an evil __repr__ can't hang deque
class BadRepr:
def __repr__(self):
self.d.pop()
return ''
b = BadRepr()
d = deque([1, b, 2])
b.d = d
repr(d)It should be fixed now |
youknowone
approved these changes
Mar 24, 2022
Member
youknowone
left a comment
There was a problem hiding this comment.
great! thank you for the long time effort!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement an helper functions to for repr function of the collections including list, tuple, set and deque.