msullivan
Follow
msullivan
Follow
Achievements
Achievements
Highlights
- 3 discussions answered
Pinned
1,033 contributions in the last year
Less
More
Contribution activity
February 2022
Created 20 commits in 2 repositories
Created a pull request in python/cpython that received 1 comment
bpo-46764: Fix wrapping bound method with @classmethod
Since #8405, @classmethod now has special case behavior to call its argument's tp_descr_get if it exists. This breaks wrapping a bound method with …
+12
−8
•
1
comment
Opened 20 other pull requests in 2 repositories
edgedb/edgedb
18
merged
- Make sure _propagate_if_expr_refs preserves inherited/computed state
- Fix collection of migration issues with inherited props
- Fix more delete trigger migration bugs
- Don't refer to qualifiedtype in error messages
- Loosen up the assertion that all generated DROP subcommands are DROPs
- Don't consider a linkprop on a multi link to be multi in a constraint on it
- Add a function for adding to path_id_mask
- Produce a proper error on an invalid regex
- Disable rebasing scalar types
- Proper errors when a scalar type tries to extend nothing
- Raise a proper error on TypeIntrospection in simple expressions
- Fix crash when filtering on a composite exclusive constraint
- Add some tests for codegen optimizations
- Add some machinery for writing assertions about the generated SQL
- Produce a real error message when an annotation value is not a string
- Reject setting a non-empty type as abstract
- Fix a collection of DDL bugs involving multi links and inhviews
- Reduce the number of calls to delta_schema in the migration happy path
edgedb/edgedb-python
1
merged
1
open
Reviewed 9 pull requests in 2 repositories
edgedb/edgedb
8 pull requests
- Provide a more detailed message in constraint error details field
- Don't consider a linkprop on a multi link to be multi in a constraint on it
- Disable rebasing scalar types
- fix candidate for #2567: We generate a pointless self join
- Make sure wait_for_sync() does NOT discard error messages
- Update test client to use the latest edgedb-python
-
drop internal prefix from
DuplicateDatabaseDefinitionError - Produce a real error message when an annotation value is not a string
python/mypy
1 pull request
Created an issue in edgedb/edgedb that received 2 comments
Add a way to require a multi property to be a proper set
Victor and I were just discussing this on slack, and currently links must be a proper set but properties can contain duplicates. It would be nice t…
2
comments