Skip to content

Adds missing information for Vault OIDC configuration#16311

Closed
ksatirli wants to merge 2 commits into
github:mainfrom
ksatirli:main
Closed

Adds missing information for Vault OIDC configuration#16311
ksatirli wants to merge 2 commits into
github:mainfrom
ksatirli:main

Conversation

@ksatirli

@ksatirli ksatirli commented Mar 16, 2022

Copy link
Copy Markdown

Why:

Closes #16310

What's being changed:

  • adds missing configuration bits and pieces
  • clarifies wording
  • expands example to include namespace to work with HCP Vault and Vault Enterprise

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome

welcome Bot commented Mar 16, 2022

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
lib/search/indexes/**
package*.json
scripts/**
translations/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Mar 16, 2022
@github-actions

Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-hashicorp-vault.md Modified Original

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review triage Do not begin working on this issue until triaged by the team and removed triage Do not begin working on this issue until triaged by the team content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review labels Mar 16, 2022
@ramyaparimi

Copy link
Copy Markdown
Contributor

@ksatirli
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ksatirli

Copy link
Copy Markdown
Author

Thank you @ramyaparimi!

Please let me know how I (@ksatirli) or we (@hashicorp) can help with this!

@ramyaparimi ramyaparimi added the needs SME This proposal needs review from a subject matter expert label Mar 25, 2022
@ethomson

Copy link
Copy Markdown
Contributor

Thanks @ksatirli - I added a note in a different PR about improving the Vault documentation. #15980 (comment)

Hopefully you and @smaeda-ks can work together to have a single set of docs for Vault? 🙏

Thanks again.

@smaeda-ks

Copy link
Copy Markdown

Hi @ethomson, yes, we both indeed are actually on the very same team! Thanks for catching that!
I've reached out to Kerim internally and we will probably be merging these two PRs into one and closing either one. We will let you know once that is completed. Thanks

@ethomson

Copy link
Copy Markdown
Contributor

Thank you so much!

smaeda-ks added a commit to smaeda-ks/docs that referenced this pull request Mar 25, 2022
@smaeda-ks

Copy link
Copy Markdown

This PR has been merged into #15980 and can be closed.

@ramyaparimi ramyaparimi closed this Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Vault OIDC guidelines

4 participants