Skip to content

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 14, 2022

Remove private empty _PyFrame_Fini() and _PyFrame_DebugMallocStats()
functions.

https://bugs.python.org/issue45786

Remove private empty _PyFrame_Fini() and _PyFrame_DebugMallocStats()
functions.
@vstinner
Copy link
Member Author

@markshannon: Is there any reason to keep these functions around?

@markshannon
Copy link
Member

_PyFrame_DebugMallocStats is marked as PyAPI_FUNC. Doesn't that mean we need to keep it?
All the rest can go.

@vstinner
Copy link
Member Author

_PyFrame_DebugMallocStats is marked as PyAPI_FUNC. Doesn't that mean we need to keep it?

Nope. It's prefixed by "_Py", so it's a private API and it can go whenever we want.

@vstinner vstinner merged commit 2217462 into python:main Mar 18, 2022
@vstinner vstinner deleted the pyframe_dead_code branch March 18, 2022 10:16
@vstinner
Copy link
Member Author

They are gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants