Skip to content

Update hello-world.md #16217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nvacan3 wants to merge 1 commit into from
Closed

Update hello-world.md #16217

nvacan3 wants to merge 1 commit into from

Conversation

@nvacan3
Copy link

@nvacan3 nvacan3 commented Mar 13, 2022

Removed line 122, I was not required to click "create pull request" after the first time.

Why:

I was not prompted to click "create a pull request" after clicking it the first time.
Closes [issue link]

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@nvacan3
Update hello-world.md
1c5c060 
Removed line 122, I was not required to click "create pull request" after the first time.
@welcome
Copy link

welcome bot commented Mar 13, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/get-started/quickstart/hello-world.md Modified Original

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review getting started get started Content related to "Getting Started" doc set and removed triage Do not begin working on this issue until triaged by the team getting started labels Mar 14, 2022
@ramyaparimi
Copy link
Contributor

ramyaparimi commented Mar 14, 2022

@nvacan3
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@myarb
Copy link
Contributor

myarb commented Mar 28, 2022 •
edited
Loading

👋🏼 @nvacan3 The expected flow is that you will click “Create pull request” to open the pull request at the end of the procedure, so I am going to close this pull request now 💛 .

Thanks for your interest in contributing to GitHub Docs 🎉

@myarb myarb closed this Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nvacan3 @ramyaparimi @myarb