Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In docs/tutorial/security at "13. Disable or limit navigation" it is recommended to use Node's parser for URLs. https://github.com/electron/electron/blob/main/docs/tutorial/security.md#13-disable-or-limit-navigation
i suggest to follow this recommendation in "5. Handle session permission requests from remote content" so that users can copy the code there in their own code. At the moment forgetting that the trailing / is necessary would enable attackers to use URLs like "https://example.com.attacker.com". https://github.com/electron/electron/blob/main/docs/tutorial/security.md#5-handle-session-permission-requests-from-remote-content
use Node's parser for URLs
No response
The text was updated successfully, but these errors were encountered:
I would like to work on this issue. Is someone working on it?
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Preflight Checklist
Problem Description
In docs/tutorial/security at "13. Disable or limit navigation" it is recommended to use Node's parser for URLs.
https://github.com/electron/electron/blob/main/docs/tutorial/security.md#13-disable-or-limit-navigation
i suggest to follow this recommendation in "5. Handle session permission requests from remote content" so that users can copy the code there in their own code. At the moment forgetting that the trailing / is necessary would enable attackers to use URLs like "https://example.com.attacker.com".
https://github.com/electron/electron/blob/main/docs/tutorial/security.md#5-handle-session-permission-requests-from-remote-content
Proposed Solution
use Node's parser for URLs
Alternatives Considered
Additional Information
No response
The text was updated successfully, but these errors were encountered: