Skip to content

ci: Check if docker daemon is running and start it if it isn't #73859

New issue
New issue
Closed
Closed
ci: Check if docker daemon is running and start it if it isn't#73859
Assignees
mehtanirav
Labels
better-engineeringRelatively self-contained tasks for better engineering contributorsgood first issuemodule: ciRelated to continuous integrationtriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
@seemethere

Description

@seemethere
seemethere
opened on Mar 7, 2022

Some workflows currently fail with the following message: (example)
Screen Shot 2022-03-07 at 10 15 59 AM

We should add a check / step to our EC2 linux setup common scripts see if the docker daemon is currently running using systemctl is-active --quiet docker and then use sudo systemctl start docker if it isn't currently running.

Change can probably be added as a separate step here:

pytorch/.github/templates/common.yml.j2

Lines 97 to 125 in a3d099e

{%- macro setup_ec2_linux() -%}
!{{ display_ec2_information() }}
- name: Log in to ECR
env:
AWS_RETRY_MODE: standard
AWS_MAX_ATTEMPTS: 5
run: |
AWS_ACCOUNT_ID=$(aws sts get-caller-identity|grep Account|cut -f4 -d\")
!{{ add_retry_to_env() }}
retry aws ecr get-login-password --region "$AWS_DEFAULT_REGION" | docker login --username AWS \
--password-stdin "$AWS_ACCOUNT_ID.dkr.ecr.$AWS_DEFAULT_REGION.amazonaws.com"
- name: Chown workspace
run: |
!{{ add_retry_to_env() }}
retry docker pull "${ALPINE_IMAGE}"
# Ensure the working directory gets chowned back to the current user
docker run --pull=never --rm -v "$(pwd)":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" .
- name: Clean workspace
run: |
rm -rf "${GITHUB_WORKSPACE}"
mkdir "${GITHUB_WORKSPACE}"
- name: "[FB EMPLOYEES] Enable SSH (Click me for login details)"
uses: seemethere/add-github-ssh-key@v1
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Preserve github env variables for use in docker
run: |
env | grep '^GITHUB' > "/tmp/github_env_${GITHUB_RUN_ID}"
{%- endmacro -%}

To be done prior to ECR login so that ECR login should work as expected (which relies on the docker daemon).

cc @seemethere @malfet @pytorch/pytorch-dev-infra

Metadata

Metadata

Assignees

Labels

better-engineeringRelatively self-contained tasks for better engineering contributorsgood first issuemodule: ciRelated to continuous integrationtriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions