Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation structure #118

Open
Arriven opened this issue Mar 5, 2022 · 15 comments
Open

Documentation structure #118

Arriven opened this issue Mar 5, 2022 · 15 comments

Comments

@Arriven
Copy link
Owner

@Arriven Arriven commented Mar 5, 2022

As new PRs come in the docs start to be a little chaotic. I think it's important to make the structure clearer to enable faster contributions.

I'm thinking about the following structure:

  • README.md - general info about the repository, links to docs/new-users.md and docs/technical-users.md should be in the beginning
  • docs/ - folder for all the other READMEs that don't belong to any other specific subfolder
  • docs/README.md - Highlited links to instructions for new and experienced users, then links to every doc that exists in the repo in a simple list
  • docs/new-users.md - instruction for new users with next to no technical experience. Should only include info about setting up the vpn and installing the app directly through releases or via docker (and clearly state that docker is an alternative to the direct install)
  • docs/technical-users.md - general info about all the ways to deploy and configure the app with links to appropriate folders/READMEs
  • docs/configuration.md - documentation including the commandline options, config file options and structure
  • path/to-specific/directory/README.md - all the docs related to a specific usage option (like already existing READMEs in terraform folder)

Please try to follow this structure when adding new documentation

@Arriven
Copy link
Owner Author

@Arriven Arriven commented Mar 5, 2022

@iamtodor since you're probably the biggest contributor to the docs yet, could you take a look at this?

@iamtodor
Copy link
Contributor

@iamtodor iamtodor commented Mar 5, 2022

@Arriven to be honest, I had literally the same assumption. The reason I didn't suggest it is I thought it would bring additional efforts

@Arriven
Copy link
Owner Author

@Arriven Arriven commented Mar 5, 2022

Yeah, started with that opinion as well but seeing the amount of contributions changed my mind 😅

@iamtodor
Copy link
Contributor

@iamtodor iamtodor commented Mar 5, 2022

would you like to move vpn list to a separate page from readme? but still having a link from readme

@Amet13
Copy link
Contributor

@Amet13 Amet13 commented Mar 5, 2022

@iamtodor @Arriven I'll prepare a proof of concept of the structure of the new doc in 10-30 mins.
Let's discuss it after I finish

@iamtodor
Copy link
Contributor

@iamtodor iamtodor commented Mar 5, 2022

@Amet13 sounds good to me!

@Arriven
Copy link
Owner Author

@Arriven Arriven commented Mar 5, 2022

VPN instructions can be a separate page, but probably also nice to include some options directly into the instructions for new users

@Arriven
Copy link
Owner Author

@Arriven Arriven commented Mar 5, 2022

@Amet13 agreed

@Amet13
Copy link
Contributor

@Amet13 Amet13 commented Mar 5, 2022

@Amet13
Copy link
Contributor

@Amet13 Amet13 commented Mar 5, 2022

The idea is to keep the main readme pretty clean.
There is also a duplicate of it in Ukrainian.
Crosslinking between ua and en versions of README.

Tool-specific docs are in their directories (for example kubernetes/{manifests,helm-chart}, terraform/{aws,gcp,...}.
General documentation for advanced users and developers is in docs/

TODO:

@iamtodor
Copy link
Contributor

@iamtodor iamtodor commented Mar 5, 2022

@Amet13 @Arriven I am not sure whether we need to keep Ukrainian instruction. I think all of us (I mean the IT community) know English at, at least pre-intermediate level. But keeping 2 separate langs would bring us double efforts

@Amet13
Copy link
Contributor

@Amet13 Amet13 commented Mar 5, 2022

@iamtodor agree, just moved it to not to break current docs.
But if we write README just once, maybe it won't be a really big effort to keep both versions

@Arriven
Copy link
Owner Author

@Arriven Arriven commented Mar 5, 2022

I think it's worth keeping the instruction for new users in Ukrainian, everything else can be English only. I'll merge PR from @Amet13 as is

Arriven pushed a commit that referenced this issue Mar 5, 2022
* SHow available platforms

* Use qemy

* Enable old arm builds

* Rem old v6

* AWS docs refactor

* Terraform fmt + doc update for GCP

* Kubernetes docs updates

* More docs

* Rm nl

* Small fixes

* Fix some doc

* Update docs/advanced-users-and-devs.md

Co-authored-by: Bohdan <Bogdannuch@gmail.com>

* Update README-ua.md

Co-authored-by: Bohdan <Bogdannuch@gmail.com>

* Fix misspell

Co-authored-by: Bohdan <Bogdannuch@gmail.com>
@iamtodor
Copy link
Contributor

@iamtodor iamtodor commented Mar 6, 2022

@Amet13 @Amet13 I would suggest having somewhere in docs (maybe for developers or it's up to your where to leave it) the following agreement:

I think we should also enforce the rule where at least two other people should validate new guides/big changes to guides and different scripts/terraform/k8s_manifests/docker-compose files which we don't have CI jobs for yet. I'll create a separate label for that

@Amet13
Copy link
Contributor

@Amet13 Amet13 commented Mar 6, 2022

I think it could be forced by implementing CODEOWNERS functionality partially

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants