Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 480: Clarify automated signing solution to remove key sharing #1711

Open
wants to merge 1 commit into
base: master
from

Conversation

@mnm678
Copy link
Contributor

@mnm678 mnm678 commented Nov 10, 2020

This pr removes references to key sharing in the automated signing section, and proposes a small modification that allows multiple maintainers to upload a package without sharing keys.

This commit adds an additional step to the automated signing solution
to allow multiple developers to upload keys for the same package
if they are maintainers of the package. This removes the need
to share keys between developers.

An alternative would be to allow each project to delegate
to separate developers. However, this solution would require
uploading additional targets metadata which may complicate
data storage on the repository.

Signed-off-by: marinamoore <mnm678@gmail.com>
@brettcannon
Copy link
Member

@brettcannon brettcannon commented Nov 10, 2020

@pfmoore we should probably change the PEP delegate for this PEP.

@pfmoore
Copy link
Member

@pfmoore pfmoore commented Nov 10, 2020

Agreed. As it's a PyPI related PEP, it should probably be @dstufft.

@mnm678
Copy link
Contributor Author

@mnm678 mnm678 commented Nov 10, 2020

@brainwane opened a pr to change the delegate in #1693.

metadata that PyPI then signs. After the initial trust is established,
developers are required to sign distributions that they upload to PyPI using
the public key's corresponding private key. The signed TUF metadata that
at least one public key's corresponding private key. The signed TUF metadata that

This comment has been minimized.

@pxeger

pxeger Nov 11, 2020
Contributor

reads better with the 's

metadata that PyPI then signs. After the initial trust is established,
developers are required to sign distributions that they upload to PyPI using
the public key's corresponding private key. The signed TUF metadata that
at least one public key's corresponding private key. The signed TUF metadata that

This comment has been minimized.

@pxeger

pxeger Nov 11, 2020
Contributor

reads better with the 's

@brettcannon brettcannon requested a review from dstufft Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants