New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility for Postponed Evaluation of Annotations (PEP 563) #15739
Comments
|
Hey! We don't have to do the bandwidth to do it right now, but we'd welcome contributions! Let me tag this as a first good issue, and let me know if you're interested in taking a stab at it! |
|
I'm glad to help with that, maybe it'll take some time. I never contribute here, I'll try to follow the CONTRIBUTING.md, post progress here and submit PR later, any discussion telling me if I'm doing right would be great. |
|
According to discussion here and solution provided by Pydantic, we may just call typing.get_type_hints on some dataclass to get type of a field instead of relying on Also, |
|
I understand; as mentioned in the thread you linked, we're unlikely to drop support for Python 3.6 just yet, but we'll definitely keep in mind that this particular issue would be solved in a simpler manner were we to drop support for it. |
|
I'm glad to help with that, maybe it'll take some time. Like sparkanime.com |
|
@rahimt420 Hello, thanks for the offer! However, I've already submitted #15795 to resolve this issue. It will be great if you could leave any suggestions there! |
Hello,
The code says that it will add compatibility for Postponed Evaluation of Annotations (PEP 563) when Python 3.9 is released (which already happened on 2020.10.5). Is there any plan to complete this?
transformers/src/transformers/hf_argparser.py
Lines 85 to 90 in 2c2a31f
The text was updated successfully, but these errors were encountered: