bpo-45528: list mmap constants in documentation #29075
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add Michael Wayne Goodman to Misc/ACKS
|
This PR is stale because it has been open for 30 days with no activity. |
Contributor
|
The bug Issue45528 contains suggestions for adding some descriptions, but I don't see them added here; eg: |
Contributor
Author
|
@MaxwellDupre Thanks! Those are my comments in issue45528 and repeated in this PR. I was hoping to get some feedback to resolve my uncertainty before committing the updates, but it never came and the PR languished. Any suggestions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some constants in the mmap module to the documentation. Previously they were (mostly) mentioned but not listed as part of the module contents.
The first commit only adds the lists of constants with some notes about applicability and availability. Prior to merging, there are a few things that could be improved:
ALLOCATIONGRANULARITYandPAGESIZEAlso, this PR also adds my name to Misc/ACKS, although it is my third contribution.
https://bugs.python.org/issue45528