Skip to content

adds display name for codespaces#5044

Merged
mislav merged 4 commits intotrunkfrom
add_display_name
Feb 9, 2022
Merged

adds display name for codespaces#5044
mislav merged 4 commits intotrunkfrom
add_display_name

Conversation

@veverkap
Copy link
Copy Markdown
Contributor

@veverkap veverkap commented Jan 14, 2022

Fixes #5042

The displayname is only available when using list --json

@veverkap ➜ /workspaces/cli (add_display_name) $ bin/gh cs list --json displayName
[
  {
    "displayName": "refactored chainsaw"
  }
]
@veverkap ➜ /workspaces/cli (add_display_name) $ bin/gh cs list
NAME                         REPOSITORY  BRANCH            STATE      CREATED AT
veverkap-cli-cli-qjv972x6xj  cli/cli     add_display_name  Available  3d

@veverkap veverkap marked this pull request as ready for review January 19, 2022 23:13
@veverkap veverkap requested a review from a team as a code owner January 19, 2022 23:13
@veverkap veverkap requested a review from mislav January 19, 2022 23:13
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Jan 19, 2022
Comment thread pkg/cmd/codespace/list.go Outdated
Copy link
Copy Markdown
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, but we shouldn't modify the table output of list command just yet.

Comment thread pkg/cmd/codespace/list.go Outdated
Comment thread pkg/cmd/codespace/list.go Outdated
Copy link
Copy Markdown
Contributor

@joshaber joshaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me but I'll defer to the folks with more gh knowledge for final approval 😄

Copy link
Copy Markdown
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thank you 🙇

Comment thread pkg/cmd/codespace/list.go Outdated
@veverkap veverkap requested review from joshaber and mislav February 7, 2022 14:39
Copy link
Copy Markdown
Contributor

@joshaber joshaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veverkap
Copy link
Copy Markdown
Contributor Author

veverkap commented Feb 9, 2022

@mislav it says you have requested changes still but when I go to look at them, there is nothing newer than the ones you opened 12 days ago.

Is there something I'm missing?

Copy link
Copy Markdown
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience!

@mislav mislav merged commit f6f8ba8 into trunk Feb 9, 2022
@mislav mislav deleted the add_display_name branch February 9, 2022 15:15
@veverkap
Copy link
Copy Markdown
Contributor Author

Thanks for your patience!

Thanks for all of your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add in display name to the codespace

5 participants