Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update dev-infra package and format json files with prettier #24303

Merged
merged 2 commits into from Feb 3, 2022

Conversation

devversion
Copy link
Member

@devversion devversion commented Jan 28, 2022

Updates the dev-infra package and formats all .json files. The ng-dev format command will
format .json files by default when prettier is enabled.

cc. @Splaktar

@devversion devversion requested review from mmalerba and as code owners Jan 28, 2022
@devversion devversion added target: patch merge safe labels Jan 28, 2022
@devversion devversion force-pushed the format-json branch 2 times, most recently from e1dbe00 to 9360f5f Compare Jan 28, 2022
Copy link
Member

@josephperrott josephperrott left a comment

LGTM

Copy link
Contributor

@mmalerba mmalerba left a comment

LGTM

@mmalerba mmalerba added the merge ready label Jan 29, 2022
Copy link
Member

@Splaktar Splaktar left a comment

LGTM other than the lint failure in devkit-migration.ts.

src/cdk/schematics/ng-update/devkit-migration.ts Outdated Show resolved Hide resolved
@devversion devversion force-pushed the format-json branch 2 times, most recently from 7bbed06 to 15f2ba4 Compare Feb 2, 2022
renovate-bot and others added 2 commits Feb 3, 2022
With the latest build of the shared dev-infra tool, we have enabled
`.json` file formatting by default if the `prettier` formatter is
configured in `.ng-dev/format.ts`.

This commit formats all JSON files to ensure lint/the format check
continues to pass.
@zarend zarend merged commit cff93c8 into angular:master Feb 3, 2022
17 checks passed
zarend added a commit that referenced this issue Feb 3, 2022
…24303)

* build: update angular shared dev-infra code

* refactor: format all json files with `ng-dev format` command

With the latest build of the shared dev-infra tool, we have enabled
`.json` file formatting by default if the `prettier` formatter is
configured in `.ng-dev/format.ts`.

This commit formats all JSON files to ensure lint/the format check
continues to pass.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
(cherry picked from commit cff93c8)
amysorto added a commit to amysorto/components that referenced this issue Feb 15, 2022
…ngular#24303)

* build: update angular shared dev-infra code

* refactor: format all json files with `ng-dev format` command

With the latest build of the shared dev-infra tool, we have enabled
`.json` file formatting by default if the `prettier` formatter is
configured in `.ng-dev/format.ts`.

This commit formats all JSON files to ensure lint/the format check
continues to pass.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Mar 6, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
merge ready merge safe target: patch
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants