Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.10] bpo-42972: Fully support GC for _winapi.Overlapped (GH-26381) #26430

Merged
merged 2 commits into from May 28, 2021
Merged

[3.10] bpo-42972: Fully support GC for _winapi.Overlapped (GH-26381) #26430

merged 2 commits into from May 28, 2021

Conversation

@Fidget-Spinner
Copy link
Contributor

@Fidget-Spinner Fidget-Spinner commented May 28, 2021 •
edited

(cherry picked from commit 0fa282c)

https://bugs.python.org/issue42972
@vstinner
Copy link
Member

@vstinner vstinner commented May 28, 2021

Windows x64: always the same crash.

test_host_port (test.test_httplib.HTTPSTest) ... ok
Windows fatal exception: access violation

@Fidget-Spinner Fidget-Spinner mentioned this pull request May 28, 2021
Merged
vstinner
vstinner approved these changes May 28, 2021
View changes
Copy link
Member

@vstinner vstinner left a comment

LGTM.

@pablogsal pablogsal merged commit 0d39951 into python:3.10 May 28, 2021
12 of 13 checks passed
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 28, 2021

@pablogsal: Please replace # with GH- in the commit message next time. Thanks!

@Fidget-Spinner Fidget-Spinner deleted the backport-0fa282c-3.10 branch May 29, 2021
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
5 participants
@Fidget-Spinner @vstinner @bedevere-bot @pablogsal @the-knights-who-say-ni