➜
This issue tracker will soon become read-only and move to GitHub.
For a smoother transition, remember to
log in and link your GitHub username to your profile.
For more information,
see this post about the migration.
Created on 2022-02-12 09:13 by LeeDongGeon1996, last changed 2022-02-15 13:43 by LeeDongGeon1996. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 31293 | merged | LeeDongGeon1996, 2022-02-12 09:25 | |
| PR 31350 | merged | LeeDongGeon1996, 2022-02-15 09:21 | |
| PR 31356 | merged | LeeDongGeon1996, 2022-02-15 10:21 | |
| Messages (7) | |||
|---|---|---|---|
| msg413120 - (view) | Author: DongGeon Lee (LeeDongGeon1996) * | Date: 2022-02-12 09:13 | |
I've found that there is an unnecessary double quote. It lost its another pair. It needs to be removed. And I would like to suggest changing its output format in docstring for consistency with similar kinds of other methods, if it was not intentional. |
|||
| msg413273 - (view) | Author: Dong-hee Na (corona10) *  |
Date: 2022-02-15 00:02 | |
New changeset 278fdd3e3a2492665b2c2888fd2f428f7f59a3f5 by DongGeon Lee in branch 'main': bpo-46728: fix docstring of combinations_with_replacement for consistency (GH-31293) https://github.com/python/cpython/commit/278fdd3e3a2492665b2c2888fd2f428f7f59a3f5 |
|||
| msg413281 - (view) | Author: Dong-hee Na (corona10) * |
Date: 2022-02-15 10:06 | |
@LeeDongGeon1996 Please send the backported patch to 3.9 also |
|||
| msg413282 - (view) | Author: Dong-hee Na (corona10) * |
Date: 2022-02-15 10:24 | |
New changeset ac55cea3cbee4d40cf7320bd691f5327cff30f13 by DongGeon Lee in branch '3.10': [3.10] bpo-46728: fix docstring of combinations_with_replacement for consistency (GH-31293) (GH-31350) https://github.com/python/cpython/commit/ac55cea3cbee4d40cf7320bd691f5327cff30f13 |
|||
| msg413286 - (view) | Author: Dong-hee Na (corona10) * |
Date: 2022-02-15 12:22 | |
New changeset ad47db34be23c5cd75ed5d5c220d4b56a9b5683c by DongGeon Lee in branch '3.9': [3.9] bpo-46728: fix docstring of combinations_with_replacement for consistency (GH-31293). (GH-31356) https://github.com/python/cpython/commit/ad47db34be23c5cd75ed5d5c220d4b56a9b5683c |
|||
| msg413287 - (view) | Author: Dong-hee Na (corona10) * |
Date: 2022-02-15 12:22 | |
Thank you DongGeon :) |
|||
| msg413290 - (view) | Author: DongGeon Lee (LeeDongGeon1996) * | Date: 2022-02-15 13:43 | |
My pleasure :) |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-02-15 13:43:30 | LeeDongGeon1996 | set | messages: + msg413290 |
| 2022-02-15 12:22:32 | corona10 | set | status: open -> closed resolution: fixed messages: + msg413287 stage: patch review -> resolved |
| 2022-02-15 12:22:13 | corona10 | set | messages: + msg413286 |
| 2022-02-15 10:24:12 | corona10 | set | messages: + msg413282 |
| 2022-02-15 10:21:26 | LeeDongGeon1996 | set | pull_requests: + pull_request29506 |
| 2022-02-15 10:06:32 | corona10 | set | messages: + msg413281 |
| 2022-02-15 10:06:05 | corona10 | set | versions: - Python 3.7, Python 3.8 |
| 2022-02-15 09:21:27 | LeeDongGeon1996 | set | pull_requests: + pull_request29499 |
| 2022-02-15 00:02:29 | corona10 | set | nosy:
+ corona10 messages: + msg413273 |
| 2022-02-12 10:59:52 | rhettinger | set | assignee: rhettinger nosy: + rhettinger |
| 2022-02-12 09:25:24 | LeeDongGeon1996 | set | keywords:
+ patch stage: patch review pull_requests: + pull_request29452 |
| 2022-02-12 09:13:23 | LeeDongGeon1996 | create | |