return element's updated index after heap change, skip news, skip issue#31226
return element's updated index after heap change, skip news, skip issue#31226ShiboXing wants to merge 1 commit into
Conversation
Simple change to return the final index of _siftdown, _siftup, heappush, making it convenient for user's potential indexable heap. User could store index after heappush, and call _siftdown or _siftup after updating
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
ShiboXing
changed the title
|
Thanks for your contribution! This is a new feature and does need an issue and NEWS entry. It should also be documented in the heapq documentation. I have no opinion on whether this feature should be added. |
|
This PR is stale because it has been open for 30 days with no activity. If the CLA is not signed within 14 days, it will be closed. See also https://devguide.python.org/pullrequest/#licensing |
|
Closing this stale PR because the CLA is still not signed. |
4 participants
Simple change to return the final index of _siftdown, _siftup, heappush, making it convenient for user's potential indexable heap.
User could store index after heappush, and call _siftdown or _siftup after updating