Skip to content

updated the section links#13297

Closed
wonntann wants to merge 1 commit intogithub:mainfrom
wonntann:patch-2
Closed

updated the section links#13297
wonntann wants to merge 1 commit intogithub:mainfrom
wonntann:patch-2

Conversation

@wonntann
Copy link
Contributor

@wonntann wonntann commented Dec 21, 2021

Wanted to add png from the blog https://github.blog/changelog/2021-04-13-table-of-contents-support-in-markdown-files/ but uploads are disabled in the images folder.
It would be beneficial to have this note regarding the Table of Contents.

Why:

Closes [issue link]

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Wanted to add png from the blog https://github.blog/changelog/2021-04-13-table-of-contents-support-in-markdown-files/ but uploads are disabled in the images folder.
It would be beneficial to have this note regarding the Table of Contents.
@welcome
Copy link

welcome bot commented Dec 21, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/github/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax.md Modified Original

@github-actions github-actions bot temporarily deployed to docs-13297--patch-2 December 21, 2021 19:58 Inactive
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review labels Dec 21, 2021
@ramyaparimi
Copy link
Contributor

@wonntann
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@felicitymay
Copy link
Contributor

@wonntann - Thanks for adding this information to the docs. Great call. 💖

After looking at this, I suggest that we add this new content as a new section "Table of contents" and put it after "Headings", since it's determined by the number of headings you add. I'll edit the PR accordingly and see if I can add an image of the button.

@felicitymay
Copy link
Contributor

@wonntann - it looks as if I don't have access to edit your PR. Can you enable the checkbox to allow maintainer edits? Then I'll be able to update your PR and get it ready to merge. Thank you! https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@felicitymay felicitymay removed the waiting for review Issue/PR is waiting for a writer's review label Jan 20, 2022
@github-actions
Copy link
Contributor

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 27, 2022
@wonntann
Copy link
Contributor Author

Thank you for looking into this matter, I will try to get to it this afternoon!

@felicitymay felicitymay removed the stale There is no recent activity on this issue or pull request label Jan 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Feb 4, 2022
@wonntann
Copy link
Contributor Author

wonntann commented Feb 5, 2022

Hi there, thank you for your patience. I was unable to access that pull request again, and since I do not have permission to push a branch, I created a new repo https://github.com/wonntann/add-headings-toc-image with the title that you were recommending. Please let me know if you need anything further from me.

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Feb 6, 2022
@felicitymay
Copy link
Contributor

@wonntann - thanks for your patience too. It looks as your fork of this repository, that you used to create this pull request, was deleted on GitHub somehow:

image

I think this explains why you weren't able to access the pull request or push to the branch 😞

@felicitymay
Copy link
Contributor

Thanks so much for your time and patience in contributing to GitHub docs. Seems like your repository for this PR was deleted somehow. Because of that, we won't be able to merge or make any changes to this PR. I can see that we have two options now:

  1. You can make changes in a new fork of this repository and open a new PR.
  2. One of the maintainers can close this PR and make the changes you suggest internally.

If you would like to open a new PR with the changes, please post the link here. Let us know how you would like to proceed with the changes.

@ihantoh

This comment was marked as spam.

@wonntann
Copy link
Contributor Author

wonntann commented Feb 7, 2022

Hi @felicitymay I put in a new pull request to the respective area within the docs. Here is the pr #15218
I didn't add the image within the folder, since I do not have permission to edit the folders, I added the image via the link from the gh blog post.
Thanks!

@felicitymay
Copy link
Contributor

Hi @wonntann - thank you so much for the second PR. I've reviewed the new PR and it will be ready to merge once we've sorted out the image 💖

Closing this PR in favor of: #15218.

@felicitymay felicitymay closed this Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants