Python: Update .expected to support Python 3.10#7844
Closed
RasmusWL wants to merge 2 commits intogithub:mainfrom
Closed
Python: Update .expected to support Python 3.10#7844RasmusWL wants to merge 2 commits intogithub:mainfrom
.expected to support Python 3.10#7844RasmusWL wants to merge 2 commits intogithub:mainfrom
Conversation
RasmusWL
added
the
depends on internal PR
RasmusWL
force-pushed
the
python-3.10
branch
3 times, most recently
from
b4a245e to
6cfaeb6
Compare
This _does_ mean that those 3 tests won't pass when using previous python versions, but I don't see any way around it. From https://docs.python.org/3/whatsnew/3.10.html: > The exception socket.timeout is now an alias of TimeoutError. > (Contributed by Christian Heimes in bpo-42413.) I think the new `__annotations__` property comes from this change, but not 100% sure > Class and module objects now lazy-create empty annotations dicts on > demand. The annotations dicts are stored in the object’s __dict__ for > backwards compatibility. This improves the best practices for working > with __annotations__; for more information, please see Annotations > Best Practices. (Contributed by Larry Hastings in bpo-43901.)
With previous commit, I had to change output for Python 3.10, but that was obviously not enough, since the test is also run for Python 2 :| Since there already was a /home/rasmus/work/code/ql/python/ql/test/2/library-tests/PointsTo/imports/` test folder, and it wasn't obvious that one of these PointsTo imports tests were a subset of the other, I renamed the old shared one slightly.
Member
Author
|
superseded by #14791 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be merged together with internal PR that changes the test to use Python 3.10 (so the tests on this PR will fail).
The changes required does mean that 3 tests won't pass when using previous python versions, but I don't see any way around it.