Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto matching for SSH tunnels #1302

Merged
merged 1 commit into from Feb 21, 2022
Merged

Add auto matching for SSH tunnels #1302

merged 1 commit into from Feb 21, 2022

Conversation

sweenu
Copy link
Contributor

@sweenu sweenu commented Dec 31, 2021

Description

This PR goes on top of #1301. It adds a ssh tunnels config section where we can auto match a regex of the DB's host to an SSH tunnel url.
With this addition, there is truly no more need for a custom script to handle tunnels, pgcli can do it all (at least in my case 😁 ).

Of course, I'll add documentation if this gets merged!

Checklist

  • I've added this contribution to the changelog.rst.
  • I've added my name to the AUTHORS file (or it's already there).
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
  • Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

@sweenu sweenu force-pushed the ssh_tunnel_conf branch 3 times, most recently from e0eaf00 to 5fe16b1 Compare Jan 4, 2022
@j-bennet
Copy link
Contributor

@j-bennet j-bennet commented Feb 18, 2022

Hi @sweenu, I rebased this PR on top of master as best I could, but some of the changes in here conflicted with #1301. Please take a look over this PR and let me know if you think it's ok to merge. Thank you!

@sweenu sweenu force-pushed the ssh_tunnel_conf branch 2 times, most recently from 7843d76 to 454881c Compare Feb 20, 2022
@sweenu
Copy link
Contributor Author

@sweenu sweenu commented Feb 20, 2022

@j-bennet Sorry for not coming back to you sooner.
Thanks for merging my other PR. I just fixed the conflicts, so it should be ready to be merged :)
I have been using this branch for a few months now without any issue.

@sweenu sweenu force-pushed the ssh_tunnel_conf branch 3 times, most recently from 8a550d6 to fe53f0a Compare Feb 20, 2022
@j-bennet j-bennet merged commit 54f0cc9 into dbcli:master Feb 21, 2022
5 checks passed
@j-bennet
Copy link
Contributor

@j-bennet j-bennet commented Feb 21, 2022

Thank you for the PR! I'll have a release out with your addition soon. This should be very useful.

@j-bennet
Copy link
Contributor

@j-bennet j-bennet commented Feb 21, 2022

@sweenu 3.4.0 is released with your change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants