C++: replace ReturnValue nodes in flow paths#7796
C++: replace ReturnValue nodes in flow paths#7796rdmarsh2 wants to merge 1 commit intogithub:mainfrom
Conversation
|
Opened as draft so I can do performance evaluations and get input from the data flow library maintainers. |
|
We could hack this without changing the shared library by repurposing the |
|
Ah, right, yeah I see the problem you're trying to solve. I think we ought to solve this entirely within the shared library without the need for a new interface predicate. |
|
Do you envision other use-cases for a "Please show this node in the final path"-feature? Because I'm leaning towards considering the specific short-coming around synthesised return nodes as a bug in the shared library, which can be fixed without such a feature. |
The return node use-case is the only one I've encountered so far, at least. Can you think of other use-cases @rdmarsh2? |
|
I didn't envision any other use-cases. If you can make a shared library fix for it, that's better than adding a new predicate to the interface. |
Improves data flow path readability for C++ by hiding the per-function
ReturnValuenodes and forcing the nodes created for eachReturnStmtto be included in the displayed path. This also adds a newnodeIsShownpredicate to the data flow library's per-language interface.