➜
This issue tracker will soon become read-only and move to GitHub.
For a smoother transition, remember to
log in and link your GitHub username to your profile.
For more information,
see this post about the migration.
Created on 2022-01-30 14:38 by sobolevn, last changed 2022-02-02 08:36 by asvetlov. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 31023 | merged | sobolevn, 2022-01-30 14:39 | |
| Messages (3) | |||
|---|---|---|---|
| msg412148 - (view) | Author: Nikita Sobolev (sobolevn) *  |
Date: 2022-01-30 14:38 | |
Right now `selectors.py` contains this check on module-level: ``` if sys.version_info >= (3, 5): ... ``` Source: https://github.com/python/cpython/blame/8fb36494501aad5b0c1d34311c9743c60bb9926c/Lib/selectors.py#L53 Learning from other modules, we tend to remove lines like this when some python version reaches EOL. And since 3.4 is not support for a long time now, this condition is always true. I propose to delete it. |
|||
| msg412342 - (view) | Author: Andrew Svetlov (asvetlov) *  |
Date: 2022-02-02 08:15 | |
New changeset 3483aa65dfebfc60a87ea9db3f20da84be41f606 by Nikita Sobolev in branch 'main': bpo-46583: remove unused `sys.version_info` check from `selectors` (GH-31023) https://github.com/python/cpython/commit/3483aa65dfebfc60a87ea9db3f20da84be41f606 |
|||
| msg412343 - (view) | Author: Andrew Svetlov (asvetlov) * |
Date: 2022-02-02 08:36 | |
The change should NOT be backported, it doesn't fix any bug but clears code a little |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-02-02 08:36:54 | asvetlov | set | messages:
+ msg412343 versions: - Python 3.9, Python 3.10 |
| 2022-02-02 08:35:32 | asvetlov | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2022-02-02 08:15:30 | asvetlov | set | messages: + msg412342 |
| 2022-01-30 14:39:36 | sobolevn | set | keywords:
+ patch stage: patch review pull_requests: + pull_request29204 |
| 2022-01-30 14:38:15 | sobolevn | create | |