Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce LF. #2391

Merged
merged 1 commit into from Aug 15, 2019
Merged

Enforce LF. #2391

merged 1 commit into from Aug 15, 2019

Conversation

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Aug 12, 2019

Previously on Windows with autocrlf=true which is the default, this led to CRLF.
@XhmikosR
Enforce LF.
9613f64 
Previously on Windows with `autocrlf=true` which is the default, this led to CRLF.
@XhmikosR
Copy link
Member Author

@XhmikosR XhmikosR commented Aug 13, 2019

BTW this requires Git >= 2.10 IIRC. An alternative would be to specify each extension but that's more verbose.

@XhmikosR
Copy link
Member Author

@XhmikosR XhmikosR commented Aug 15, 2019

Can we get this merged?

@Trott
Copy link
Member

@Trott Trott commented Aug 15, 2019

@nodejs/website This could use some reviews.

lpinca
lpinca approved these changes Aug 15, 2019
View changes
@lpinca
Copy link
Member

@lpinca lpinca commented Aug 15, 2019

LGTM. We use the same on ws https://github.com/websockets/ws/blob/master/.gitattributes

Trott
Trott approved these changes Aug 15, 2019
View changes
@Trott Trott merged commit e1dd6e2 into nodejs:master Aug 15, 2019
1 check passed
@XhmikosR XhmikosR deleted the master-xmr-lf branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott

@lpinca lpinca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
3 participants
@XhmikosR @Trott @lpinca