C#: Guard against AssociatedSymbol not being an IEventSymbol#7772
Merged
hvitved merged 4 commits intogithub:mainfrom Jan 31, 2022
Merged
C#: Guard against AssociatedSymbol not being an IEventSymbol#7772hvitved merged 4 commits intogithub:mainfrom
AssociatedSymbol not being an IEventSymbol#7772hvitved merged 4 commits intogithub:mainfrom
Conversation
Apply same logic as for property/indexer accessors to account for cases where the associated event cannot be determined. I have not been able to reproduce such cases locally, though we have seen reports of it happening.
tamasvajk
reviewed
Jan 28, 2022
Contributor
tamasvajk
left a comment
tamasvajk
left a comment
There was a problem hiding this comment.
I've added some minor questions.
tamasvajk
previously approved these changes
Jan 28, 2022
tamasvajk
approved these changes
Jan 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply same logic as for property/indexer accessors to account for cases where the associated event cannot be determined. I have not been able to reproduce such cases locally, though we have seen reports of it happening.