Use GitHub actions#2039
Conversation
Add Maven Wrapper for using in GitHub Actions Remove Travis
Using the latest (4.0-beta1) does not work on Java 8 since it is compiled with Java 9
chris922
left a comment
chris922
left a comment
There was a problem hiding this comment.
Really awesome, @filiphr ! :)
I am not used to GitHub actions but the yml looks straight forward. Interesting to see that you have to fix some Locale and TimeZone things, what was the main reason for this? E. g. why do you have to reset to the default locale or fix the timezone to Europe/Berlin?
|
Thanks for the review @chris922.
Some of the tests were assuming Europe/Berlin timezone. Some other tests were changing the default timezone, but never resetting it. So I aligned that. Probably Travis was running in a different Timezone. I think that the Github runners are on the UTC timezone |
2 participants
Fixes #2019
Switch to using GitHub Actions instead of Travis.
The Java 8 testing is slightly slower, but that is because we are not using caching for maven, so it downloads the dependencies every time. We can optimise this later on.