bpo-41031: Match C and Python code formatting of unprintable exceptio… #28139
Conversation
…ns and exceptions in the __main__ module.
vstinner
reviewed
Sep 3, 2021
erlend-aasland
reviewed
Sep 3, 2021
erlend-aasland
approved these changes
Sep 3, 2021
serhiy-storchaka
reviewed
Sep 5, 2021
| @@ -169,7 +169,7 @@ def _some_str(value): | |||
| try: | |||
| return str(value) | |||
| except: | |||
| return '<unprintable %s object>' % type(value).__name__ | |||
| return '<exception str() failed>' | |||
The former message contains more information. Would not be better to change other places?
The information is duplicated because the exception is printed separately.
serhiy-storchaka
approved these changes
Sep 5, 2021
|
Thanks @serhiy-storchaka . @pablogsal @ambv do you want to backport this? It’s a very minor thing, but keeping the code aligned to make other back ports easier may be a consideration. |
|
Too late for 3.10.0 and so I'm inclined to let those backports go and only include this in 3.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
…ns and exceptions in the main module.
https://bugs.python.org/issue41031
The text was updated successfully, but these errors were encountered: