Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ddev service enable/disable and ddev get commands, fixes #3068 #3516

Merged
merged 25 commits into from Jan 20, 2022

Conversation

@rfay
Copy link
Contributor

@rfay rfay commented Jan 12, 2022

The Problem/Issue/Bug:

How this PR Solves The Problem:

Add ddev service enable/disable/install/remove commands

TODO:

  • Docs need to explain the new commands (ddev service get/enable/disable)
  • Docs need to explain how to create a 3rd party service repository
    • Use template
    • Update ...
    • Adding tests
  • Tests for the ddev commands
  • Registry for recipes
  • Tests for the first recipes/services
  • Make a template with full setup including tests, etc.
  • Ability to use local files (needed for tests)
  • Allow use of
    • github short ref (rfay/solr), which will get latest release
    • Link to a tarball (can be a link to another release tarball)
    • Directory that is checked out
    • Local tarball

Manual Testing Instructions:

There's lots to do here but

  • Add memcached service with ddev get drud/ddev-memcached && ddev restart. Verify functionality.
  • ddev service enable and ddev service disable

Automated Testing Overview:

Tests added for ddev get, ddev service, and the various utility functions.

Release/Deployment notes:

@rfay rfay marked this pull request as draft Jan 12, 2022
@rfay rfay changed the title Provide ddev service enable/disable/install/remove commands Provide ddev service enable/disable/install/remove commands, fixes #3068 Jan 13, 2022
@rfay rfay force-pushed the 20220112_ddev_service branch 5 times, most recently from 2614974 to b20057a Jan 18, 2022
@rfay rfay force-pushed the 20220112_ddev_service branch from b20057a to 882c2e6 Jan 19, 2022
@rfay rfay marked this pull request as ready for review Jan 19, 2022
@rfay rfay changed the title Provide ddev service enable/disable/install/remove commands, fixes #3068 Provide ddev service enable/disable and ddev get commands, fixes #3068 Jan 19, 2022
@rfay rfay merged commit e54753a into drud:master Jan 20, 2022
18 of 20 checks passed
@rfay rfay deleted the 20220112_ddev_service branch Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant