Skip to content

docs: fixed meetup URL#44585

Closed
SerheyDolgushev wants to merge 1 commit into
angular:masterfrom
SerheyDolgushev:fix-meetup-link
Closed

docs: fixed meetup URL#44585
SerheyDolgushev wants to merge 1 commit into
angular:masterfrom
SerheyDolgushev:fix-meetup-link

Conversation

@SerheyDolgushev
Copy link
Copy Markdown
Contributor

@SerheyDolgushev SerheyDolgushev commented Dec 30, 2021 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Meetup URL contains a quotation mark at the end.

What is the new behavior?

The redundant extra quotation mark is removed from meetup URL.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove Bot requested a review from josephperrott December 30, 2021 15:34
@yousafnawaz
Copy link
Copy Markdown
Contributor

yousafnawaz commented Dec 30, 2021

@SerheyDolgushev , it seems that you haven't signed the CLA (see here). Note that this is necessary in order to accept any contribution.
Thank you.

@SerheyDolgushev
Copy link
Copy Markdown
Contributor Author

SerheyDolgushev commented Dec 31, 2021

@yousafnawaz I just signed the CLA. can you please re-run CLA check? Thank you! :)

gkalpak
gkalpak approved these changes Jan 3, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @SerheyDolgushev 👍

@gkalpak gkalpak removed the request for review from josephperrott January 3, 2022 16:15
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker comp: docs target: patch This PR is targeted for the next patch release type: bug/fix labels Jan 3, 2022
@ngbot ngbot Bot added this to the Backlog milestone Jan 3, 2022
@dylhunn
Copy link
Copy Markdown
Contributor

dylhunn commented Jan 4, 2022

This PR was merged into the repository by commit 62a5027.

dylhunn pushed a commit that referenced this pull request Jan 4, 2022
@SerheyDolgushev @dylhunn
docs: fixed meetup URL (#44585)
845038c 
PR Close #44585
@dylhunn dylhunn closed this in 62a5027 Jan 4, 2022
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Feb 4, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gkalpak gkalpak gkalpak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@SerheyDolgushev @yousafnawaz @dylhunn @gkalpak