Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable no_leading_underscores_for_local_identifiers #96422

Merged
merged 2 commits into from Jan 21, 2022
Merged

Enable no_leading_underscores_for_local_identifiers #96422

merged 2 commits into from Jan 21, 2022
+948 −949

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Jan 10, 2022 •
edited

Evaluating what this lint (which may be added to package:lints, dart-lang/lints#58) means for the flutter code base.

Before we can submit and enable this we need to wait for the fix of dart-lang/linter#3127 to roll into our repository. (Analysis will fail before then.)

/cc @pq
@pq
Copy link
Contributor

@pq pq commented Jan 10, 2022

The fix for field formal params is in the in-flight 1.18.0 (dart-lang/linter#3140).

@goderbauer goderbauer force-pushed the no_leading_underscores_for_local_identifiers branch from f12c0a8 to a49eb41 Jan 13, 2022
@goderbauer
Copy link
Member Author

@goderbauer goderbauer commented Jan 13, 2022

@christopherfujino for the tool
@gspencergoog for the API doc samples

gspencergoog
gspencergoog approved these changes Jan 13, 2022
View changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Wow. I wonder why there were so many of these in non-tests? I can see doing it accidentally in a test, since it feels like a class scope, but it's really an inner function. But it seems weird to do that with regular locals.

Thanks for turning that on!

@goderbauer goderbauer force-pushed the no_leading_underscores_for_local_identifiers branch from a54acd3 to 8913d98 Jan 13, 2022
christopherfujino
christopherfujino approved these changes Jan 14, 2022
View changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

tools change LGTM

@goderbauer goderbauer merged commit 5684b9f into flutter:master Jan 21, 2022
126 checks passed
@goderbauer goderbauer deleted the no_leading_underscores_for_local_identifiers branch Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino

@gspencergoog gspencergoog

@Piinks Piinks

Assignees
No one assigned
Labels
a: accessibility a: animation a: tests a: text input d: api docs d: examples documentation f: cupertino f: material design f: routes f: scrolling framework team tool
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
4 participants
@goderbauer @pq @christopherfujino @gspencergoog