New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move `final` detection for `Enum` in `checker.py` #11984

Merged

sobolevn merged 6 commits into python:master from sobolevn:issue-11850

Jan 18, 2022

Member

sobolevn commented Jan 13, 2022

Changes:

I've moved all final detection logic from semanal.py to checker.py. Why? Because we need type checking! For example, methods, properties, and other descriptors are not counted as Enum membres
We don't modify .is_final anymore. Why? It is too disruptive. Now this is a special-case for Enum only

Closes #11850

The text was updated successfully, but these errors were encountered:

JukkaL approved these changes

View changes

Collaborator

JukkaL left a comment

Thanks, looks good! It makes sense to do these checks during type checking. Left a few nits; feel to merge when you've addressed them (and fixed the merge conflict).

mypy/util.py Outdated Show resolved Hide resolved

test-data/unit/check-enum.test Show resolved Hide resolved

sobolevn force-pushed the issue-11850 branch from b121f34 to c5fe7be

sobolevn mentioned this pull request

Fix CI by allowing it to fail on 3.11 #12003

Merged

sobolevn added 5 commits

WIP

2378b57


          Move final detection for Enum in checker.py, refs python#11850

ea552ac


          Fixes CI

3a34b48


          Fixes CI

55beda1


          Address review

69af50c

sobolevn force-pushed the issue-11850 branch from c5fe7be to 69af50c

Member Author

sobolevn commented Jan 18, 2022 •

edited

Fixed merge conflicts, rebased, waiting for the CI to pass and merging 🎉


          Fixes CI

f9cbe7f

Member Author

sobolevn commented Jan 18, 2022

@JukkaL I am going to use these guidelines for merging process: https://github.com/python/mypy/blob/master/CONTRIBUTING.md#core-developer-guidelines

sobolevn merged commit 0a03ba0 into python:master

14 checks passed

Member Author

sobolevn commented Jan 18, 2022

Done! My first merged PR 🎉

Member

JelleZijlstra commented Jan 18, 2022

Congratulations!

tushar-deepsource added a commit to deepsourcelabs/mypy that referenced this issue


          Move final detection for Enum in checker.py (python#11984)

3e8f32f

Fixes python#11850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment