bpo-10202: Added resilience for broken or troublesome connections in ftplib (GH-30747) #30747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks for EOF in storbinary and storlines and raises excpetion if not completed successfully. Also, added SO_LINGER flag on socket shutdown. Attempt is made to send outstanding data on shutdown in socket module, for Linux only.
MaxwellDupre
changed the title
|
Hi, I have fixed the ftplib.rst spaces issue but dont know how to update the file in here. Done a git push origin but cant do a push upstream (error: 403). |
|
Oh and how do I add a skip news label? |
You can't 🙂 only core developers and triagers can, I'm afraid. I am a triager, but I'm afraid I think this probably warrants a news entry if it warrants a You can add a news entry using https://blurb-it.herokuapp.com/ |
|
Ok, thanks for letting me know, I won’t worry about it anymore. But yes
understand your comment I can add an entry in news. Thanks.
On Sat, 22 Jan 2022 at 13:46, Alex Waygood ***@***.***> wrote:
...
|
|
Cant get changes back into this PR, so will create another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks for EOF in storbinary and storlines and raises excpetion if not
completed successfully. Also, added SO_LINGER flag on socket shutdown.
Attempt is made to send outstanding data on shutdown in socket module,
for Linux only.
https://bugs.python.org/issue10202