Skip to content

bpo-46481: Implement vectorcall for weakref.ref.__call__ method. #30820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 23, 2022
Merged

bpo-46481: Implement vectorcall for weakref.ref.__call__ method. #30820

merged 7 commits into from
Jan 23, 2022

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Jan 23, 2022 •
edited by bedevere-bot
Loading

@corona10 corona10 requested a review from vstinner January 23, 2022 06:54
@corona10 corona10 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @corona10 for commit cdcde65 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2022
@corona10 corona10 added the performance Performance or resource usage label Jan 23, 2022
@corona10
Copy link
Member Author

@vstinner

buildbot/AMD64 Windows8.1 Refleaks PR — Build done.

This failure is not related to this PR :)

kumaraditya303
kumaraditya303 reviewed Jan 23, 2022
View reviewed changes
vstinner
vstinner reviewed Jan 23, 2022
View reviewed changes
@corona10 corona10 requested a review from vstinner January 23, 2022 14:20
vstinner
vstinner reviewed Jan 23, 2022
View reviewed changes
@corona10 corona10 requested a review from vstinner January 23, 2022 14:31
vstinner
vstinner approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just added minor coding style remarks. The overall change LGTM ;-) It's a nice optimization!

vstinner
vstinner reviewed Jan 23, 2022
View reviewed changes
vstinner
vstinner reviewed Jan 23, 2022
View reviewed changes
vstinner
vstinner approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Now it's perfect! :-D

@corona10 corona10 merged commit 76dc047 into python:main Jan 23, 2022
@corona10 corona10 deleted the bpo-46481 branch January 23, 2022 15:39
@corona10 corona10 mentioned this pull request Mar 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

performance Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@corona10 @bedevere-bot @vstinner @kumaraditya303 @the-knights-who-say-ni