Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upupdates from upstream #3
Open
Conversation
… assignment expression
```js
let param = 'default value';
if (object)
param = object.param; // <= prefer-destructuring
}
// ...
```
I think that `param = object.param;` is better than `({ param } = object);` because it is easier to read and tedious to write brackets by hand.
MDN: [Destructuring assignment](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment)
…date rule configs
…int-plugin-react`, `tape`
Seen a few pull requests for the React style guide that try to introduce features that aren't yet in stage >= 3 (static class fields for i.e), so I've decided to add a comment to the beginning of the guide. Not sure if this is the right place to put it, but here it is. This disclaimer might help: 1) give the community an idea what standards this guide is based on 2) prevent redundant pull requests
…-import`
Adds a change to eslint-config-airbnb and eslint-config-airbnb-base to pull a list of rules from the project root and return a config with all rules turned off except the whitespace rules explicitly listed in the array. Also adds entry point data to readme.
Adds eslint config extends with only whitespace rules enabled Merge pull request airbnb#1749 from airbnb/whitespace-rules
…le with node 4
This allows to import non-JavaScript files through the main export of a dependency's package.json. The following would trigger an error before, but is fine with the new configuration: ```js import 'roboto-fontface'; ```
…tch eslint 4.18.0 In eslint v4.18.0 separate settings are introduced for imports and exports for the `object-curly-newline` rule. Without this change, there is different behavior when updating eslint to this version.
We recently had an incident where this rule would have prevented infinite loops in Hypernova and in the browser.
…o-param-reassign`
Merge pull request airbnb#255 from estelle/master
…dencies` check
…eslint-find-rules`
…yclical dependencies
…3, due to a controversial change in v2.5 Fixes airbnb#2195.
The translation for Chinese (Simplified) is outdated. Changed to an up-to-date translation that synced with current English version, enhanced expressions for better readability, and also added notes of technical terms for Chinese readers.
…rbnb-base/legacy`
## Why is the change being made? This change is made because the Airbnb documentation states to "avoid a newline at the beginning of files", yet the code does not follow this. ## What has changed to address the problem? This change fixes the `no-multiple-empty-lines` rule by setting max beginning of file (`maxBOF`) to from 1 to 0. ## How was this change tested? This change was tested with `npm test`. ## Related docs https://github.com/airbnb/javascript#whitespace--no-multiple-empty-lines
…-props-no-spreading`
…ram-reassign`
…gin-react`, `babel-preset-airbnb`, `eslint-find-rules`, `in-publish`, `tape`
…d v4 Co-authored-by: Kristóf Poduszló <kripod@protonmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
…ugin-jsx-a11y`
…import/no-cycle` `maxDepth` option
…ponents
…rules`, `eslint-plugin-jsx-a11y`, `eslint-plugin-react`
Fixes airbnb#2274.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
inaw-tihor commentedJun 3, 2020
updates from upstream repo for guidelines on react