Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .tool-versions to latest Ruby version #1209

Merged
merged 1 commit into from Dec 16, 2021
Merged

Update .tool-versions to latest Ruby version #1209

merged 1 commit into from Dec 16, 2021

Conversation

cpjmcquillan
Copy link
Contributor

@cpjmcquillan cpjmcquillan commented Dec 15, 2021

Summary

In #1176, .tool-versions was updated to be less specific about the ruby
version. asdf isn't smart enough to figure out which Ruby version to use,
though.

This updates the Ruby version specified in .tool-versions to the latest
release (3.0.3).

@cpjmcquillan cpjmcquillan requested a review from as a code owner Dec 15, 2021
@cpjmcquillan cpjmcquillan changed the title Update .tool-versions to latest Ruby version Update .tool-versions to latest Ruby version Dec 15, 2021
@cpjmcquillan
Update .tool-versions to latest Ruby version
44e0025 
In github#1176, `.tool-versions` was updated to be less specific about the ruby
version. asdf isn't smart enough to figure out which Ruby version to use,
though.

This updates the Ruby version specified in `.tool-versions` to the latest
release (3.0.3).
@Spone
Copy link
Collaborator

@Spone Spone commented Dec 16, 2021

Sorry about that! Thanks for the fix :)

Spone
Spone approved these changes Dec 16, 2021
View changes
@Spone
Copy link
Collaborator

@Spone Spone commented Dec 16, 2021

I'm not very familiar with asdf, but can we use latest:3.0 as described here: https://asdf-vm.com/manage/versions.html#install-latest-stable-version

@cpjmcquillan
Copy link
Contributor Author

@cpjmcquillan cpjmcquillan commented Dec 16, 2021 •
edited

I'm not very familiar with asdf, but can we use latest:3.0 as described here: https://asdf-vm.com/manage/versions.html#install-latest-stable-version

You can install the latest version like that, but the problem is that asdf isn't clever enough to allow 3.0 in .tool-versions and a version matching 3.0.x installed. If you only specify 3.0 in .tool-versions, asdf will raise an error when you try to run any ruby in that directory (e.g bundle).

No preset version installed for command bundle
Please install a version by running one of the following:

asdf install ruby 2.6

If .tool-versions instead said ruby non-existent-version you would get the same error.

No preset version installed for command bundle
Please install a version by running one of the following:

asdf install ruby non-existent-version

@Spone
Copy link
Collaborator

@Spone Spone commented Dec 16, 2021

Thanks for your explanation :)

@cpjmcquillan
Copy link
Contributor Author

@cpjmcquillan cpjmcquillan commented Dec 16, 2021 •
edited

Here is a useful explanation about why, too.

@joelhawksley joelhawksley merged commit 63fd477 into github:main Dec 16, 2021
22 checks passed
@cpjmcquillan cpjmcquillan deleted the update-tool-version branch Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spone Spone

@joelhawksley joelhawksley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpjmcquillan @Spone @joelhawksley