JSQLParser / JSqlParser Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Gradle Buildsystem #1271
Conversation
Implement a basic Gradle/Maven compatibility workaround for the Special Oracle Test
|
Ups! I just noticed that the TRAVIS CI will automatically prefer the Gradle as well, I have not been expecting that. |
Good, then we we will have it one way or the other.
When I tried to activate JJDoc with the Maven Plugin it was a real struggle. All documentation dead or stale.
Same here. I never touched Gradle before and was actually scared because I thought it might be complex.
I moved all the Special Oracle Test SQL Files into the correct folder according to the package of the test class, when I had to adjust the hard coded location in the Test Class (from "target/..." to "build/..." for Gradle). |
|
I'd like to add a personal note: My own programs are still running on ANT and I am new to Maven and Gradle. I touched Maven before Gradle for the sake of working on JSQLParser and POI and H2. That said, I liked Gradle instantly and will migrate my own projects now. |
|
I looked into it and indeed the maven javacc plugin we are using is quite old. But as those javacc people introduced a new gradle plugin, they did with the maven plugin with the advantages you mentioned (IMHO). <!-- https://mvnrepository.com/artifact/org.javacc.plugin/javacc-maven-plugin -->
<dependency>
<groupId>org.javacc.plugin</groupId>
<artifactId>javacc-maven-plugin</artifactId>
<version>3.0.3</version>
</dependency>I will integrate this one, so we have a direct comparision. I have my problems with gradle to be honest. But my experiences were some years old. So I will give it a try. |
|
On Sun, 2021-07-18 at 23:25 -0700, Tobias wrote:
I will integrate this one, so we have a direct comparision.
I think it boils down to 3 considerations
1) JavaCC support (and the JaCoCo Reports integration) <-- You have
solved that, they are on par.
2) Integration of any (Java-) programs without plugins (the RR
diagrams) <-- Certainly works in both, but I found Gradle much simpler
3) Simplicity and Build Speed <-- I found Gradle better in that regard,
especially for repeating builds
I have my problems with gradle to be honest. But my experiences were
some years old. So I will give it a try.
Fair enough, I was really not expecting you to be too excited about
replacing the build system.
And again, it is not the hill I want to die on as long as we get
everything working with Maven. The main reason I started to work on
that was 2) the RR diagrams.
Thank you for looking at it, I appreciate.
Cheers!
|



Advantages of the Gradle Build:
a) JaCoCo reports now Test Coverage before Push and also illustrates the uncovered parts directly in the Netbeans IDE. Reports are activated.
b) SpotBugs revealed one Prio 1 issue, I have fixed that already. I deactived any Prio 2 issue for the time being, but we should look at these later. Reports are activated.
c) PMD also revealed 6 Prio 1 issues (not covered by our custom rules). I deactivated these for the time being, but we should look at these later. Reports are activated.
I kept the Maven Build in place and right now you can choose if you build per Maven or per Gradle.
The "Deploy to Maven Central/Sonartype" is prepared but I have not been able to test it yet (because I do not have the credentials/access)
I have not provided a Website Build yet, but have prepared a Sphinx Skeleton which would show:
I would like to conclude it when you have digested/agree on the new infrastructure.
The text was updated successfully, but these errors were encountered: