Skip to content

GitHub Pages: clarify when user action is required#13644

Merged
ethanpalm merged 5 commits into
github:mainfrom
alzafacon:patch-2
Mar 2, 2022
Merged

GitHub Pages: clarify when user action is required#13644
ethanpalm merged 5 commits into
github:mainfrom
alzafacon:patch-2

Conversation

@alzafacon
Copy link
Copy Markdown
Contributor

@alzafacon alzafacon commented Jan 2, 2022

I was confused by the phrase "we automatically attempt to secure".
It helps to be explicit that user action is still required

Why:

Closes #13643

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Fidel Coria added 2 commits January 1, 2022 21:27
explicit that secure does not mean setup
f6e9efd 
I was confused by the phrase "we automatically attempt to secure".
It helps to be explicit that user action is still required
clarify action required for apex domain setup
8ac6e04
@welcome
Copy link
Copy Markdown

welcome Bot commented Jan 2, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 2, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/pages/configuring-a-custom-domain-for-your-github-pages-site/about-custom-domains-and-github-pages.md Modified Original
content/pages/configuring-a-custom-domain-for-your-github-pages-site/managing-a-custom-domain-for-your-github-pages-site.md Modified Original

@github-actions github-actions Bot temporarily deployed to docs-13644--patch-2 January 2, 2022 06:03 Inactive
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review labels Jan 3, 2022
@ramyaparimi
Copy link
Copy Markdown
Contributor

ramyaparimi commented Jan 3, 2022

@alzafacon
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@github-actions github-actions Bot temporarily deployed to docs-13644--patch-2 January 14, 2022 21:22 Inactive
@ramyaparimi ramyaparimi added the needs SME This proposal needs review from a subject matter expert label Mar 1, 2022
@janiceilene janiceilene added sme approved and removed needs SME This proposal needs review from a subject matter expert labels Mar 2, 2022
@janiceilene
Copy link
Copy Markdown
Contributor

janiceilene commented Mar 2, 2022

This has been approved by an SME, who would like us to:

remove the second “but you need to make the DNS changes to use the www subdomain”

Now we're just waiting on a writer review! Thanks so much for your patience @alzafacon 💛

ethanpalm
ethanpalm previously approved these changes Mar 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ethanpalm ethanpalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR, @alzafacon! I'm applying one small change that was requested by the Pages team and then I'll get this branch up to date and merged ⚡

Thank you for taking the time to improve the GitHub docs!

Comment thread ...figuring-a-custom-domain-for-your-github-pages-site/about-custom-domains-and-github-pages.md Outdated
@ethanpalm ethanpalm enabled auto-merge March 2, 2022 22:57
@ethanpalm ethanpalm added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Mar 2, 2022
@ethanpalm ethanpalm merged commit cf6822b into github:main Mar 2, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 2, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ethanpalm ethanpalm ethanpalm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Custom Domain for GitHub Pages Docs: clarify when user needs to take action

4 participants

@alzafacon @ramyaparimi @janiceilene @ethanpalm