Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating readability and technical info #478

Open
wants to merge 2 commits into
base: master
from

Conversation

@OdinsHat
Copy link

@OdinsHat OdinsHat commented Feb 25, 2019

I took you up on the offer to help on the project. I've done like the commit message says. Updated based on latest technical features. Readability and tidy up. Let me know if you want anything.

OdinsHat added 2 commits Feb 25, 2019
Added some extra information and made some improvements in grammar, structure and readability. I consider this the beginning of a general tidy up of the docs and manual section taking hints from tmuxinator and teamocli
Comparisons were given better structure and titles with updated information on features. Ambiguous titles have been made clearer
@OdinsHat

This comment has been minimized.

Copy link
Owner Author

@OdinsHat OdinsHat commented on 89239b4 Feb 25, 2019

I took you up on the offer to help on the project. I've done like the commit message says. Updated based on latest technical features. Readability and tidy up. Let me know if you want anything.

@codecov-io
Copy link

@codecov-io codecov-io commented Feb 25, 2019

Codecov Report

Merging #478 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
- Coverage   75.06%   74.93%   -0.13%     
==========================================
  Files           5        5              
  Lines         794      794              
  Branches      231      231              
==========================================
- Hits          596      595       -1     
  Misses        146      146              
- Partials       52       53       +1
Impacted Files Coverage Δ
tmuxp/workspacebuilder.py 90.9% <0%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4aa2e2...89239b4. Read the comment docs.

@tony
Copy link
Member

@tony tony commented May 12, 2019

@OdinsHat Nice!

@tony
Copy link
Member

@tony tony commented Aug 16, 2020

@OdinsHat Hi there, sorry about this! Can I get another rebase?

I just merged #623 which moves us to a poetry packaging setup and will runs the PR through GitHub actions.

@tony
Copy link
Member

@tony tony commented Oct 25, 2020

@OdinsHat Can you please rebase this? I don't have permission to merge it due to conflicts

I'd like you to get credit for the PR itself (not only the commit)

I can also opt to cherry-pick the commits into master and resolve conflicts on my end - but I prefer you get full recognition in the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.