Skip to content

Small screen resolution precision#13659

Closed
mathieu-aubin wants to merge 3 commits into
github:mainfrom
mathieu-aubin:patch-2
Closed

Small screen resolution precision#13659
mathieu-aubin wants to merge 3 commits into
github:mainfrom
mathieu-aubin:patch-2

Conversation

@mathieu-aubin
Copy link
Copy Markdown

@mathieu-aubin mathieu-aubin commented Jan 3, 2022

It appears that the branch '{% octicon "git-branch" aria-label="The branch icon" %}' gets removed past a certain resolution and this tutorial, altho correct, becomes somewhat of a big question mark.

I have never had the issue happen until i started using this 15 inches NEC monitor SIDEWAYS as a second monitor on my current dev stack in order to test out somewhat accurately some odd resolutions mobiles have and their effects on browsing.

I couldn't figure out why i had been able to delete branches from the web gui for all i can remember and now, very very confusingly, couldnt figure out it for the life of me. Even so i had to google it because it killed my chi.

Decided to add to the docs, please feel free to do whatever you want with that and, thanks!

Why:

caused an issue as described when using small resolution screens which hide the subject

Closes #13662

What's being changed:

just a precision within a NOTE block

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

It appears that the branch '{% octicon "git-branch" aria-label="The branch icon" %}' gets removed past a certain resolution and this tutorial, altho correct, becomes somewhat of a big question mark.

I have never had the issue happen until i started using this 15 inches NEC monitor SIDEWAYS as a second monitor on my current dev stack in order to test out somewhat accurately some odd resolutions mobiles have and their effects on browsing.

I couldn't figure out why i had been able to delete branches from the web gui for all i can remember and now, very very confusingly, couldnt figure out it for the life of me. Even so i had to google it because it killed my chi.

Decided to add to the docs, please feel free to do whatever you want with that and, thanks!
@welcome
Copy link
Copy Markdown

welcome Bot commented Jan 3, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 3, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-and-deleting-branches-within-your-repository.md Modified Original

@github-actions github-actions Bot temporarily deployed to docs-13659--patch-2 January 3, 2022 05:19 Inactive
@mathieu-aubin
Copy link
Copy Markdown
Author

mathieu-aubin commented Jan 3, 2022

This is the result of command xrandr on the computer i'm using with regards to the monitor in question.

Screen 0: minimum 320 x 200, current 2688 x 1080, maximum 16384 x 16384
VGA-1 connected 768x1024+1920+0 right (normal left inverted right x axis y axis) 304mm x 228mm
   1024x768      75.03 +  70.07    60.00* 
   832x624       74.55  
   800x600       72.19    75.00    60.32    56.25  
   640x480       75.00    72.81    66.67    59.94  
   720x400       70.08  

It is rotated to the right. and is part of a larger display server of (1920+768)=2688 px

The icon only shows when i am at 70% zoomm using firefox.

Thanks!

realized it was best to write the full description since many other things use the same icon

{% octicon "git-branch" aria-label="The branch icon" %} NUMBER branches
sorry, no idea what happenned.
@github-actions github-actions Bot temporarily deployed to docs-13659--patch-2 January 3, 2022 06:38 Inactive
@github-actions github-actions Bot temporarily deployed to docs-13659--patch-2 January 3, 2022 06:42 Inactive
@mathieu-aubin
Copy link
Copy Markdown
Author

Could also mention that the thing can be accessible via url /branches within a project

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review labels Jan 3, 2022
@ramyaparimi
Copy link
Copy Markdown
Contributor

@mathieu-aubin
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ethomson
Copy link
Copy Markdown
Contributor

ethomson commented Feb 7, 2022

I think that we should fix this bug instead of documenting the workaround. 🤔 Let me pass this on to the engineering team.

@davidstaheli
Copy link
Copy Markdown
Contributor

@mathieu-aubin, thanks for doing this! I agree with @ethomson above that we should treat this as a bug to fix so that the workaround wouldn't be necessary.

@skedwards88
Copy link
Copy Markdown
Contributor

Thanks for weighing in! I'm going to close out this PR since we will fix the bug instead of documenting this, but we hope to see more contributions from you in the future @mathieu-aubin !

@skedwards88 skedwards88 closed this Feb 8, 2022
@mathieu-aubin
Copy link
Copy Markdown
Author

Great. All i hoped for was some kind of resolution. But... is this fair to call this a BUG? I mean... it seems the site IS functionnal yet, the DOCS dont take the programming into consideration. Is this a bug or an omission, a mishap in writting docs, maybe not writting as universally as it best would be.

Dont get me wrong, i will, again, repeat; im all about resolution on issues that might pose new users or heck, all for any kind of resolution.

I really am puzzled with the fact that its called a bug - i dont see 'wording' or 'written explanations' being able to be affected by what we can call a bug (as in the moth flew into the glass tube amp and fucked it all).

I appreciate whatever input you have on my concern, no matter opinionated with regards to me being 'pulling hairs' or bein anal about a docs group being accurate.

That being said, its all 'write' with me, i wont loose sleep over it as i dont do much of that lately!

Cheers and may the shwartz be with j00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small screen resolution and icon display

5 participants