Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Push upgrades pack into lib pack#628

Merged
aeisenberg merged 2 commits into
mainfrom
aeisenberg/upgrades/work
Jan 11, 2022
Merged

Push upgrades pack into lib pack#628
aeisenberg merged 2 commits into
mainfrom
aeisenberg/upgrades/work

Conversation

@aeisenberg

Copy link
Copy Markdown
Contributor

PR Related to https://github.com/github/semmle-code/pull/40918
Removes the upgrades pack and uses ql/lib/upgrades instead.

@aeisenberg aeisenberg requested a review from a team as a code owner December 10, 2021 22:38
@aeisenberg aeisenberg force-pushed the aeisenberg/upgrades/work branch 2 times, most recently from e26ebaf to 3936bbd Compare December 10, 2021 22:43
@aeisenberg aeisenberg removed the request for review from a team December 11, 2021 00:18
@aeisenberg aeisenberg marked this pull request as draft December 11, 2021 00:18
Comment thread Makefile Outdated
@aeisenberg aeisenberg marked this pull request as ready for review December 14, 2021 17:12
@aeisenberg aeisenberg requested review from a team and dbartol December 14, 2021 17:13
PR Related to github/semmle-code#40918
Removes the upgrades pack and uses ql/lib/upgrades instead.

Also, fix malformed parameter in instruction.

Co-authored-by: Chris Smowton <smowton@github.com>
@aeisenberg aeisenberg force-pushed the aeisenberg/upgrades/work branch from 1d60b0e to 49d239f Compare January 4, 2022 19:32
@aeisenberg aeisenberg requested a review from smowton January 5, 2022 20:14

@dbartol dbartol left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeisenberg aeisenberg merged commit 2b8e4b2 into main Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants