Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(root-layout): support gradient colors on shade cover #9626

Merged
merged 6 commits into from Jan 14, 2022

Conversation

NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Oct 28, 2021

PR Checklist

What is the current behavior?

Right now only standard hex/rgb(a) color values are supported via the RootLayout api, e.g.

getRootLayout()
        .open(view, {
          shadeCover: {
            color: 'rgba(0,0,0,.5)',

What is the new behavior?

This maintains the existing behavior while also supporting linear-gradient as well, e.g.

getRootLayout()
        .open(view, {
          shadeCover: {
            color: 'linear-gradient(to top, #fff, rgba(0, 0, 0, .7))',

@NathanWalker NathanWalker force-pushed the feat/rootlayout-gradient-shadecover branch from f55e62d to 9495910 Compare Oct 28, 2021
@NathanWalker NathanWalker marked this pull request as ready for review Dec 16, 2021
@NathanWalker NathanWalker changed the base branch from master to release/8.2.0 Jan 14, 2022
@NathanWalker NathanWalker merged commit 06c00d2 into release/8.2.0 Jan 14, 2022
2 of 3 checks passed
@NathanWalker NathanWalker deleted the feat/rootlayout-gradient-shadecover branch Jan 14, 2022
NathanWalker added a commit that referenced this issue Feb 14, 2022
Co-authored-by: William Juan <williamjuan027@gmail.com>
NathanWalker added a commit that referenced this issue Feb 18, 2022
Co-authored-by: William Juan <williamjuan027@gmail.com>
NathanWalker added a commit that referenced this issue Mar 1, 2022
Co-authored-by: William Juan <williamjuan027@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
@nativescript/core
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants