JS: Update featurization for absent features optimization #7376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrymercer
force-pushed
the
henrymercer/js-atm-absent-features-optimization
branch
from
33e0ac8
to
2f9776d
henrymercer
changed the base branch from
main
to
henrymercer/js-atm-only-featurize-with-flow
Absent features are now represented implicitly by the absence of a row in the `tokenFeatures` relation, rather than explicitly by an empty string. This leads to improved runtime performance. To enable this implicit representation, we pass the set of supported token features to the `scoreEndpoints` HOP. Requires CodeQL CLI v2.7.4.
henrymercer
force-pushed
the
henrymercer/js-atm-absent-features-optimization
branch
from
2f9776d
to
144ec8c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Absent features are now represented implicitly by the absence of a row in the
tokenFeaturesrelation, rather than explicitly by an empty string. This leads to improved runtime performance. To enable this implicit representation, we pass the set of supported token features to thescoreEndpointsHOP.This change requires CodeQL CLI v2.7.4 — we will likely want to hold off on merging this until that version of the CLI is released.
Internal PR backlinked.
The text was updated successfully, but these errors were encountered: