Skip to content

C#: Convert flow summaries for JSon.NET #7348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaelnebel merged 5 commits into from
Dec 13, 2021
Merged

C#: Convert flow summaries for JSon.NET #7348

michaelnebel merged 5 commits into from
Dec 13, 2021

Conversation

@michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Dec 10, 2021

No description provided.

@github-actions github-actions bot added the C# label Dec 10, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2021

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    Others,"``Dapper``, ``Microsoft.ApplicationBlocks.Data``, ``MySql.Data.MySqlClient``",,,131,
+    Others,"``Dapper``, ``Microsoft.ApplicationBlocks.Data``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``",,74,131,
-    Totals,,3,32,353,5
+    Totals,,3,106,353,5
  • Changes to framework-coverage-csharp.csv:
+ Newtonsoft.Json,,,74,,,,,,,74

@michaelnebel michaelnebel force-pushed the csharp-mad-as-csv-json branch from 03fea20 to 2c684d3 Compare December 10, 2021 13:31
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2021

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    Others,"``Dapper``, ``Microsoft.ApplicationBlocks.Data``, ``MySql.Data.MySqlClient``",,,131,
+    Others,"``Dapper``, ``Microsoft.ApplicationBlocks.Data``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``",,73,131,
-    Totals,,3,32,353,5
+    Totals,,3,105,353,5
  • Changes to framework-coverage-csharp.csv:
+ Newtonsoft.Json,,,73,,,,,,,73

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2021

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    Others,"``Dapper``, ``Microsoft.ApplicationBlocks.Data``, ``MySql.Data.MySqlClient``",,,131,
+    Others,"``Dapper``, ``Microsoft.ApplicationBlocks.Data``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``",,73,131,
-    Totals,,3,32,353,5
+    Totals,,3,105,353,5
  • Changes to framework-coverage-csharp.csv:
+ Newtonsoft.Json,,,73,,,,,,,73

@michaelnebel michaelnebel marked this pull request as ready for review December 10, 2021 15:07
@michaelnebel michaelnebel requested a review from a team as a code owner December 10, 2021 15:07
hvitved
hvitved previously approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michaelnebel michaelnebel force-pushed the csharp-mad-as-csv-json branch from ec91b08 to dd86a2e Compare December 13, 2021 08:39
@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2021

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",3,561,28,5
+    System,"``System.*``, ``System``",3,585,28,5
-    Others,"``Dapper``, ``Microsoft.ApplicationBlocks.Data``, ``MySql.Data.MySqlClient``",,,131,
+    Others,"``Dapper``, ``Microsoft.ApplicationBlocks.Data``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``",,73,131,
-    Totals,,3,568,353,5
+    Totals,,3,665,353,5
  • Changes to framework-coverage-csharp.csv:
+ Newtonsoft.Json,,,73,,,,,,,73,
- System,28,3,561,,4,,23,1,3,468,93
+ System,28,3,585,,4,,23,1,3,490,95

@michaelnebel michaelnebel requested a review from hvitved December 13, 2021 09:34
@michaelnebel michaelnebel force-pushed the csharp-mad-as-csv-json branch from dd86a2e to f32d464 Compare December 13, 2021 09:51
@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2021

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    Others,"``Dapper``, ``Microsoft.ApplicationBlocks.Data``, ``MySql.Data.MySqlClient``",,,131,
+    Others,"``Dapper``, ``Microsoft.ApplicationBlocks.Data``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``",,73,131,
-    Totals,,3,592,353,5
+    Totals,,3,665,353,5
  • Changes to framework-coverage-csharp.csv:
+ Newtonsoft.Json,,,73,,,,,,,73,

@michaelnebel michaelnebel merged commit 7ff2ee6 into github:main Dec 13, 2021
@michaelnebel michaelnebel deleted the csharp-mad-as-csv-json branch December 13, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hvitved hvitved hvitved approved these changes

Assignees

No one assigned

Labels

C#

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelnebel @hvitved