Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby: Include StringComponents in the CFG #7440

Open
wants to merge 4 commits into
base: hmac/regexp-interpolations
Choose a base branch
from
Open

Ruby: Include StringComponents in the CFG #7440

wants to merge 4 commits into from

Conversation

@hvitved
Copy link
Contributor

@hvitved hvitved commented Dec 17, 2021

Code review suggestions for #7334.
@hvitved hvitved requested a review from as a code owner Dec 17, 2021
@github-actions github-actions bot added the Ruby label Dec 17, 2021
@hvitved hvitved mentioned this pull request Dec 17, 2021
Open
nickrolfe
nickrolfe reviewed Dec 17, 2021
View changes
ruby/ql/lib/codeql/ruby/controlflow/internal/ControlFlowGraphImpl.qll
@@ -1365,6 +1365,10 @@ module Trees {
final override ControlFlowTree getChildElement(int i) { result = this.getComponent(i) }
}

private class StringComponentComponentTree extends LeafTree, StringComponent {
StringComponentComponentTree() { not this instanceof StringInterpolationComponent }
Copy link
Contributor

@nickrolfe nickrolfe Dec 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are interpolations included in the CFG elsewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickrolfe nickrolfe

Assignees
No one assigned
Labels
Ruby
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@hvitved @nickrolfe