Fix __isabstractmethod__ for class/static methods and properties#3479
Merged
Conversation
Includes a minor departure from CPython implementation of inspect.isabstract because TPFLAGS_IS_ABSTRACT is not set in obj.__flags__.
youknowone
reviewed
Nov 29, 2021
|
|
||
| def isabstract(object): | ||
| """Return true if the object is an abstract base class (ABC).""" | ||
| # TODO: RUSTPYTHON |
Member
There was a problem hiding this comment.
How about leaving the original code as commented-out and put this comments on line 305? So future contributor can notice what's changed in the source code.
Contributor
Author
There was a problem hiding this comment.
Sure! Fixed this.
|
|
||
| #[pyproperty(magic)] | ||
| fn isabstractmethod(&self, vm: &VirtualMachine) -> PyObjectRef { | ||
| let getter_abstract = match self.getter.read().to_owned() { |
Member
There was a problem hiding this comment.
@coolreader18 is to_owned the best way to handle this?
Member
There was a problem hiding this comment.
@coolreader18 do you have any idea about this? otherwise i will merge this PR
Contributor
Author
There was a problem hiding this comment.
@youknowone & @coolreader18, Just wanted to check in on this PR. Should I work on trying to remove the to_owned()?
youknowone
approved these changes
Nov 30, 2021
Member
|
I am sorry to keep this unmerged for long time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes a minor departure from CPython implementation of
inspect.isabstractbecause TPFLAGS_IS_ABSTRACT is not set inobj.__flags__. Not sure if this is a problem but happy to revert this change if it is.