bpo-24937: Replace the extension module porting HOWTO by links to external projects #9317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminp
approved these changes
Sep 14, 2018
Doc/howto/cporting.rst
Outdated
| @@ -6,252 +6,34 @@ | |||
| Porting Extension Modules to Python 3 | |||
| ************************************* | |||
|
|
|||
| :author: Benjamin Peterson | |||
|
|
|||
|
|
|||
| .. topic:: Abstract | |||
There was a problem hiding this comment.
Let's just delete the abstract.
ncoghlan
approved these changes
Sep 20, 2018
yahya-abou-imran
pushed a commit
to yahya-abou-imran/cpython
that referenced
this pull request
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I've talked with Benjamin, and he's OK with just removing the "Porting Extension Modules to Python 3" HOWTO, and replacing it by links to external guides that do a much better job at documenting this.
Also, Python 2.6 and 3.0 is EOL; it should be fine to scrub capsulethunk.
https://bugs.python.org/issue24937