Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Add link to FileHandler in logging (GH-21940) #21940

Merged
merged 5 commits into from Sep 1, 2020

Conversation

andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Aug 22, 2020

No link exists in the doc

Automerge-Triggered-By: @vsajip

@andresdelfino andresdelfino requested a review from vsajip as a code owner Aug 22, 2020
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Aug 22, 2020
Copy link
Member

@vsajip vsajip left a comment

The table contains numerous other references to FileHandler and StreamHandler - I would suggest changing them all to cross-references, or leaving them all as is.

@bedevere-bot
Copy link

bedevere-bot commented Aug 23, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@andresdelfino
Copy link
Contributor Author

andresdelfino commented Aug 23, 2020

Thanks for reviewing, @vsajip I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented Aug 23, 2020

Thanks for making the requested changes!

@vsajip: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from vsajip Aug 23, 2020
@vsajip vsajip added 🤖 automerge PR will be merged once it's been approved and all CI passed skip issue skip news labels Aug 31, 2020
Copy link
Member

@vsajip vsajip left a comment

Apparently there are conflicts - please resolve.

@bedevere-bot
Copy link

bedevere-bot commented Aug 31, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@andresdelfino
Copy link
Contributor Author

andresdelfino commented Aug 31, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented Aug 31, 2020

Thanks for making the requested changes!

@vsajip: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from vsajip Aug 31, 2020
@andresdelfino
Copy link
Contributor Author

andresdelfino commented Aug 31, 2020

For some reason, make -C Doc/ PYTHON=../python SPHINXOPTS="-q -W --keep-going -j4" doctest suspicious html is not using the created venv.

make htmlview works correctly locally.

@vsajip
Copy link
Member

vsajip commented Sep 1, 2020

I'll close and reopen the pull request to see if that makes a difference.

@vsajip vsajip closed this Sep 1, 2020
@vsajip vsajip reopened this Sep 1, 2020
vsajip
vsajip approved these changes Sep 1, 2020
@vsajip vsajip changed the title [doc] Add link to FileHandler in logging [doc] Add link to FileHandler in logging (GH-21940) Sep 1, 2020
@vsajip vsajip merged commit f5a16b4 into python:master Sep 1, 2020
3 checks passed
@andresdelfino andresdelfino deleted the add_link_to_filehandler branch Sep 1, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Co-authored-by: Andrés Delfino <adelfino@onapsis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir 🤖 automerge PR will be merged once it's been approved and all CI passed skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants