Fix build on RTD #12551
Merged
Fix build on RTD #12551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mik-laj
reviewed
Nov 22, 2020
.pre-commit-config.yaml
Outdated
| @@ -524,6 +524,7 @@ repos: | |||
| language: system | |||
| entry: "./scripts/ci/pre_commit/pre_commit_mypy.sh" | |||
| files: ^docs/.*\.py$ | |||
| exclude: rtd-deprecatipn | |||
There was a problem hiding this comment.
Since we have two conf.py files and no init.py, mypy thinks we have two modules with the same name.
turbaszek
approved these changes
Nov 23, 2020
|
The PR is ready to be merged. No tests are needed! |
danielenricocahall
added a commit
to danielenricocahall/airflow
that referenced
this issue
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Related: #12541
RTD is very tricky and requires the name of the file conf.py even though the file may be named differently in the configuration file.
Failed build: https://readthedocs.org/projects/airflow/builds/12396195/
Build from my branch: https://readthedocs.org/projects/apache-airflow-dev/builds/
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
The text was updated successfully, but these errors were encountered: