New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS: Add support for TypeScript 4.5 #7216
Open
erik-krogh
wants to merge
9
commits into
github:main
Choose a base branch
from
erik-krogh:ts45
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Evaluation looks fine.
I didn't add new syntax nodes for the new import assertions.
And I didn't add support for import assertions in the JS parser.
E.g.
import obj from "./something.json" assert { type: "json" };.It's currently a stage 3 proposal.
TypeScript added support for the
#name in objsyntax, which we didn't support in the JS parser.So I implemented the ECMAScript proposal first. (It's a stage 4 proposal).
The
#name in objsyntax is weird.For context:
name in objtests whether the string-value contained in the variablenameis present as a field inobj.However,
#name in objtests whether the private field#name(from the current class) is present inobj.That also means that two
#name in objexpressions in two different classes will refer to two different#namefields.It appears to be the only situation across JavaScript where an identifier does not refer to a value, but instead refers to the existence of a field.
So the implementation is somewhat hacky, but that comes from it being a special case in the language itself.
The text was updated successfully, but these errors were encountered: