New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Add more path-injection sinks from os and tempfile modules
#7259
Open
RasmusWL
wants to merge
12
commits into
github:main
Choose a base branch
from
RasmusWL:even-more-path-injection-sinks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since that's the idiomatic way to use this module
I also renamed the arguments to match what the keyword argument is called. It doesn't matter too much for these specific tests, but for the tests I'm about to add, it makes things a lot easier to get an overview of. Oh, and a test failure :O
I went through https://docs.python.org/3.10/library/os.html in order, and added all the functions that works on paths. `lstat` and `statvfs` were already modeled, but did not have any tests.
These operate on file descriptors, and not on paths. file descriptors doesn't fit into the rest of our modeling, so I would rather remove them than to make it look like it's properly handled. I also did not include any of the functions that work on file descriptors when looking through all of `os`. So this keeps everything consistent at least ;)
I think it's more readable to have only one to cover all of these changes, even though they came in through different PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: